Skip to content

Issue1389 detailed house#1404

Merged
annadellisola merged 120 commits intoopen-ideas:masterfrom
LoneMeertens:issue1389_DetailedHouse
Jul 8, 2025
Merged

Issue1389 detailed house#1404
annadellisola merged 120 commits intoopen-ideas:masterfrom
LoneMeertens:issue1389_DetailedHouse

Conversation

@LoneMeertens
Copy link
Contributor

@LoneMeertens LoneMeertens commented Dec 23, 2024

Fixes #1389.
More detailed documentation and result visualization can be added if deemed valuable. This can be combined with open-ideas/__CrashCourse__#25. and #1374

@lucasverleyen
Copy link
Member

lucasverleyen commented Dec 24, 2024

@LoneMeertens, thank you for addressing the issue! I really like the new structure, a great improvement. :-) Also, adding more documentation/explanation provides significant added value.

  • I suggest including Refactoring exercise 3 __CrashCourse__#25 and Update Tutorial IDEAS #1374 as well in this PR, which seems more convenient than having too many issues and PRs related to the same models.
  • Regarding more detailed documentation and result visualisation, I suggest maintaining consistency with the SimpleHouse tutorial from IBPSA and following a similar approach. This tutorial has been thoroughly reviewed recently and is consequently in good shape.
  • Additionally, we can add DetailedHouse10 as a final Example at the same level as SimpleHouse.

@LoneMeertens
Copy link
Contributor Author

LoneMeertens commented Dec 24, 2024

@lucasverleyen Thank you for the detailed feedback and suggestions! 😊 I'm glad you like the new structure and the additional documentation.

I’ll take this up and include open-ideas/CrashCourse#25 and Update Tutorial IDEAS #1374 in this PR as suggested—it does make sense to consolidate related issues and PRs.

Regarding the documentation and result visualization, I'll align it with the SimpleHouse tutorial from IBPSA to ensure consistency and maintain the high standard of quality. I'll also add DetailedHouse10 (as DetailedHouse) as a final example, positioned at the same level as SimpleHouse.

Thanks again for the valuable input!

@lucasverleyen
Copy link
Member

@LoneMeertens perfect! Thanks a lot! In the mean time, I have looked at the unit tests, but currently, I am not able to solve the issues. DetailedHouse5 does work, but the other examples do not and I don't know why... to be continued in the new year ;-)

@lucasverleyen
Copy link
Member

lucasverleyen commented Jan 2, 2025

@jelgerjansen good catch (__Dymola_Commands)! I suggest adding this to the documentation of the testing framework: https://github.com/open-ideas/IDEAS/blob/master/IDEAS/Resources/Scripts/tests/README.md under Developing new tests. Something like: "Make sure that the file name and path in the model annotation under __Dymola_Comands correspond to the name and path to the .mos file in Resources/Scripts/Dymola/... " What do you think?

Copy link
Contributor

@jelgerjansen jelgerjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LoneMeertens thank you for addressing this issue. Most comments are related to model documentation and syntax.

The models previously didn't run due to the reference to an unexisting mos file in __Dymola_Commands(). This does not generates warnings when translating the model in Dymola, but it does for the unit tests. I solved this issue via commits 8cca500 and e8f49c5

Once you've also addressed the other related issues (e.g. #1374), I'll do another review.

@jelgerjansen
Copy link
Contributor

@jelgerjansen good catch (__Dymola_Commands)! I suggest adding this to the documentation of the testing framework: https://github.com/open-ideas/IDEAS/blob/master/IDEAS/Resources/Scripts/tests/README.md under Developing new tests. Something like: "Make sure that the file name and path in the model annotation under __Dymola_Comands correspond to the name and path to the .mos file in Resources/Scripts/Dymola/... " What do you think?

@lucasverleyen the __Dymola_Commands is not used when running the unit tests, but links the mos file to the model such that the experiment in the mos file is executed when running the "Simulate and plot" command in Dymola. Note that you don't need a __Dymola_Commands to run the unit tests (which is for example why DetailedHouse5 could be run without problems), but is easier if you want to run unit tests mos files of certain models in Dymola. Therefore, I would maybe not add it, as it is no hard requirement.

If you add it, the file in __Dymola_Commands should of course be linked to the correct mos file (but this is rather a general requirement rather than a unit test requirement). I think that BuildingsPy performs a more detailed check of the model when translating compared to Dymola, as the latter did not throw any errors.

Copy link
Member

@lucasverleyen lucasverleyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annadellisola thanks a lot for finalising this issue. Looks great! I only have some textual remarks. Once the new reference results are generated, fine for me to merge :-)

annadellisola and others added 11 commits July 8, 2025 09:04
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Copy link
Contributor

@annadellisola annadellisola Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increase of "number of continuous time states" due to the use of two different components for ceiling and SlabOnGround, and the change from IDEAS.Buildings.Validation.Data.Constructions.HeavyFloor to IDEAS.Buildings.Data.Constructions.FloorOnGround.

Update Ref Results Old Reference Results
cei.layMul.monLay[1].monLayDyn.T[1] cei.layMul.monLay[1].monLayDyn.T[2] cei.layMul.monLay[2].monLayDyn.T[1] cei.layMul.monLay[3].monLayDyn.T[1] outWalEas.layMul.monLay[1].monLayDyn.T[1] outWalEas.layMul.monLay[1].monLayDyn.T[2] outWalEas.layMul.monLay[2].monLayDyn.T[1] outWalEas.layMul.monLay[3].monLayDyn.T[1] outWalEas.layMul.monLay[3].monLayDyn.T[2] outWalNor.layMul.monLay[1].monLayDyn.T[1] outWalNor.layMul.monLay[1].monLayDyn.T[2] outWalNor.layMul.monLay[2].monLayDyn.T[1] outWalNor.layMul.monLay[3].monLayDyn.T[1] outWalNor.layMul.monLay[3].monLayDyn.T[2] outWalSou.layMul.monLay[1].monLayDyn.T[1] outWalSou.layMul.monLay[1].monLayDyn.T[2] outWalSou.layMul.monLay[2].monLayDyn.T[1] outWalSou.layMul.monLay[3].monLayDyn.T[1] outWalSou.layMul.monLay[3].monLayDyn.T[2] outWalWes.layMul.monLay[1].monLayDyn.T[1] outWalWes.layMul.monLay[1].monLayDyn.T[2] outWalWes.layMul.monLay[2].monLayDyn.T[1] outWalWes.layMul.monLay[3].monLayDyn.T[1] outWalWes.layMul.monLay[3].monLayDyn.T[2] slaOnGro.layGro.monLay[1].monLayDyn.T[1] slaOnGro.layGro.monLay[1].monLayDyn.T[2] slaOnGro.layGro.monLay[1].monLayDyn.T[3] slaOnGro.layGro.monLay[1].monLayDyn.T[4] slaOnGro.layGro.monLay[1].monLayDyn.T[5] slaOnGro.layGro.monLay[1].monLayDyn.T[6] slaOnGro.layGro.monLay[1].monLayDyn.T[7] slaOnGro.layGro.monLay[2].monLayDyn.T[1] slaOnGro.layGro.monLay[2].monLayDyn.T[2] slaOnGro.layGro.monLay[2].monLayDyn.T[3] slaOnGro.layGro.monLay[2].monLayDyn.T[4] slaOnGro.layGro.monLay[3].monLayDyn.T[2] slaOnGro.layMul.monLay[1].monLayDyn.T[1] slaOnGro.layMul.monLay[1].monLayDyn.T[2] slaOnGro.layMul.monLay[1].monLayDyn.T[3] slaOnGro.layMul.monLay[1].monLayDyn.T[4] slaOnGro.layMul.monLay[2].monLayDyn.T[1] slaOnGro.layMul.monLay[3].monLayDyn.T[1] slaOnGro.layMul.monLay[4].monLayDyn.T[1] win.heaCapGlaExt.T win.heaCapGlaInt.T zon.airModel.vol.dynBal.m zon.airModel.vol.dynBal.medium.Xi[1] zon.airModel.vol.dynBal.U floor.layMul.monLay[1].monLayDyn.T[1] floor.layMul.monLay[1].monLayDyn.T[2] floor.layMul.monLay[2].monLayDyn.T[1] outerWall.layMul.monLay[1].monLayDyn.T[1] outerWall.layMul.monLay[1].monLayDyn.T[2] outerWall.layMul.monLay[2].monLayDyn.T[1] outerWall.layMul.monLay[3].monLayDyn.T[1] outerWall.layMul.monLay[3].monLayDyn.T[2] outerWall1.layMul.monLay[1].monLayDyn.T[1] outerWall1.layMul.monLay[1].monLayDyn.T[2] outerWall1.layMul.monLay[2].monLayDyn.T[1] outerWall1.layMul.monLay[3].monLayDyn.T[1] outerWall1.layMul.monLay[3].monLayDyn.T[2] outerWall2.layMul.monLay[1].monLayDyn.T[1] outerWall2.layMul.monLay[1].monLayDyn.T[2] outerWall2.layMul.monLay[2].monLayDyn.T[1] outerWall2.layMul.monLay[3].monLayDyn.T[1] outerWall2.layMul.monLay[3].monLayDyn.T[2] outerWall3.layMul.monLay[1].monLayDyn.T[1] outerWall3.layMul.monLay[1].monLayDyn.T[2] outerWall3.layMul.monLay[2].monLayDyn.T[1] outerWall3.layMul.monLay[3].monLayDyn.T[1] outerWall3.layMul.monLay[3].monLayDyn.T[2] window.heaCapGlaExt.T window.heaCapGlaInt.T zone.airModel.vol.dynBal.m zone.airModel.vol.dynBal.medium.Xi[1] zone.airModel.vol.dynBal.U

The figure below shows the difference in the reference variables:
image
Ref_res: InternalWall for ceiling and floor with highly insulated BESTEST heavy wall as construction type

Test: distinct SlabOnGround with FloorOnGround construction type, and ceiling lead to higher heat losses

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same considerations of DetailedHouse1 holds for the change in the reference results.
The figure below shows the change in reference variables:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same considerations of DetailedHouse1 holds for the change in the reference results.
The figure below shows the change in reference variables:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same considerations of DetailedHouse1 holds for the change in the reference results.
The figure below shows the change in reference variables:
image

Copy link
Contributor

@annadellisola annadellisola Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increase of "number of continuous time states" due to the use of two different components for ceiling and SlabOnGround, and the change from IDEAS.Buildings.Validation.Data.Constructions.HeavyFloor to IDEAS.Buildings.Data.Constructions.FloorOnGround in both zones.

The figure below shows the change in reference variables:
image
Ref_res: InternalWall for ceiling and floor with highly insulated BESTEST heavy wall as construction type in both zones

Test: distinct SlabOnGround with FloorOnGround construction type, and ceiling lead to higher heat losses. The error in recZon1, with a south-oriented window is higher.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increase of "number of continuous time states" due to the use of two different components for ceiling and SlabOnGround, the change from IDEAS.Buildings.Validation.Data.Constructions.HeavyFloor to IDEAS.Buildings.Data.Constructions.FloorOnGround in both zones and the addition of pumEmi:

Update Ref Results Old Reference Results
EEl.y heaPum.con.vol.dynBal.U heaPum.eva.vol.dynBal.U pumEmi.motSpe.y pumEmi.vol.dynBal.U pumPri.motSpe.y pumPri.vol.dynBal.U pumSec.motSpe.y pumSec.vol.dynBal.U rad.vol[1].dynBal.U rad.vol[2].dynBal.U rad.vol[3].dynBal.U rad.vol[4].dynBal.U rad.vol[5].dynBal.U rad1.vol[1].dynBal.U rad1.vol[2].dynBal.U rad1.vol[3].dynBal.U rad1.vol[4].dynBal.U rad1.vol[5].dynBal.U rectangularZoneTemplate.airModel.vol.dynBal.m rectangularZoneTemplate.airModel.vol.dynBal.medium.Xi[1] rectangularZoneTemplate.airModel.vol.dynBal.U rectangularZoneTemplate.intC.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.intC.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.intC.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.intC.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.intC.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.outA.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.outA.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.outA.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.outA.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.outA.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.outB.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.outB.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.outB.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.outB.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.outB.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.outCei.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.outCei.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.outCei.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.outCei.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.outD.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.outD.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.outD.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.outD.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.outD.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.slaOnGro.layGro.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.slaOnGro.layGro.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.slaOnGro.layGro.monLay[1].monLayDyn.T[3] rectangularZoneTemplate.slaOnGro.layGro.monLay[1].monLayDyn.T[4] rectangularZoneTemplate.slaOnGro.layGro.monLay[1].monLayDyn.T[5] rectangularZoneTemplate.slaOnGro.layGro.monLay[1].monLayDyn.T[6] rectangularZoneTemplate.slaOnGro.layGro.monLay[1].monLayDyn.T[7] rectangularZoneTemplate.slaOnGro.layGro.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.slaOnGro.layGro.monLay[2].monLayDyn.T[2] rectangularZoneTemplate.slaOnGro.layGro.monLay[2].monLayDyn.T[3] rectangularZoneTemplate.slaOnGro.layGro.monLay[2].monLayDyn.T[4] rectangularZoneTemplate.slaOnGro.layGro.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.slaOnGro.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.slaOnGro.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.slaOnGro.layMul.monLay[1].monLayDyn.T[3] rectangularZoneTemplate.slaOnGro.layMul.monLay[1].monLayDyn.T[4] rectangularZoneTemplate.slaOnGro.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.slaOnGro.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.slaOnGro.layMul.monLay[4].monLayDyn.T[1] rectangularZoneTemplate.winA.heaCapGlaExt.T rectangularZoneTemplate.winA.heaCapGlaInt.T rectangularZoneTemplate1.airModel.vol.dynBal.m rectangularZoneTemplate1.airModel.vol.dynBal.medium.Xi[1] rectangularZoneTemplate1.airModel.vol.dynBal.U rectangularZoneTemplate1.outB.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.outB.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.outB.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.outB.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate1.outB.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate1.outC.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.outC.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.outC.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.outC.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate1.outC.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate1.outCei.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.outCei.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.outCei.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.outCei.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate1.outD.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.outD.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.outD.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.outD.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate1.outD.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate1.slaOnGro.layGro.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.slaOnGro.layGro.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.slaOnGro.layGro.monLay[1].monLayDyn.T[3] rectangularZoneTemplate1.slaOnGro.layGro.monLay[1].monLayDyn.T[4] rectangularZoneTemplate1.slaOnGro.layGro.monLay[1].monLayDyn.T[5] rectangularZoneTemplate1.slaOnGro.layGro.monLay[1].monLayDyn.T[6] rectangularZoneTemplate1.slaOnGro.layGro.monLay[1].monLayDyn.T[7] rectangularZoneTemplate1.slaOnGro.layGro.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.slaOnGro.layGro.monLay[2].monLayDyn.T[2] rectangularZoneTemplate1.slaOnGro.layGro.monLay[2].monLayDyn.T[3] rectangularZoneTemplate1.slaOnGro.layGro.monLay[2].monLayDyn.T[4] rectangularZoneTemplate1.slaOnGro.layGro.monLay[3].monLayDyn.T[2] rectangularZoneTemplate1.slaOnGro.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.slaOnGro.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.slaOnGro.layMul.monLay[1].monLayDyn.T[3] rectangularZoneTemplate1.slaOnGro.layMul.monLay[1].monLayDyn.T[4] rectangularZoneTemplate1.slaOnGro.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.slaOnGro.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate1.slaOnGro.layMul.monLay[4].monLayDyn.T[1] rectangularZoneTemplate1.winC.heaCapGlaExt.T rectangularZoneTemplate1.winC.heaCapGlaInt.T senTemSup.T tan.vol[1].dynBal.U tan.vol[2].dynBal.U val.val.actPos.y val1.val.actPos.y EEl.y heaPum.con.vol.dynBal.U heaPum.eva.vol.dynBal.U pumpPrim.motSpe.y pumpPrim.vol.dynBal.U pumpSec.motSpe.y pumpSec.vol.dynBal.U rad.vol[1].dynBal.U rad.vol[2].dynBal.U rad.vol[3].dynBal.U rad.vol[4].dynBal.U rad.vol[5].dynBal.U rad1.vol[1].dynBal.U rad1.vol[2].dynBal.U rad1.vol[3].dynBal.U rad1.vol[4].dynBal.U rad1.vol[5].dynBal.U rectangularZoneTemplate.airModel.vol.dynBal.m rectangularZoneTemplate.airModel.vol.dynBal.medium.Xi[1] rectangularZoneTemplate.airModel.vol.dynBal.U rectangularZoneTemplate.intC.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.intC.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.intC.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.intC.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.intC.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.intFlo.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.intFlo.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.intFlo.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.intFlo.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.intFlo.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.outA.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.outA.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.outA.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.outA.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.outA.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.outB.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.outB.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.outB.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.outB.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.outB.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.outD.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.outD.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.outD.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.outD.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.outD.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.winA.heaCapGlaExt.T rectangularZoneTemplate.winA.heaCapGlaInt.T rectangularZoneTemplate1.airModel.vol.dynBal.m rectangularZoneTemplate1.airModel.vol.dynBal.medium.Xi[1] rectangularZoneTemplate1.airModel.vol.dynBal.U rectangularZoneTemplate1.intFlo.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.intFlo.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.intFlo.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.intFlo.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate1.intFlo.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate1.outB.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.outB.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.outB.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.outB.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate1.outB.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate1.outC.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.outC.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.outC.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.outC.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate1.outC.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate1.outD.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.outD.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.outD.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.outD.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate1.outD.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate1.winC.heaCapGlaExt.T rectangularZoneTemplate1.winC.heaCapGlaInt.T senTemSup.T tan.vol[1].dynBal.U tan.vol[2].dynBal.U val.val.actPos.y val1.val.actPos.y

The figure below shows the change in reference variables:
image
In the Test results the TSensor is lower due to change in floor construction type.
Less on/off cycle of the heat pump occur due to the decoupling of production and emission system through the tank.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same considerations of DetailedHouse1 holds for the change in the reference results.
The figure below shows the change in reference variables:
image
In the Test results the TSensor is lower due to change in floor construction type.
Less on/off cycle of the heat pump and a more stable condenser temperature results from decoupling the production and emission system through the tank.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The figure below shows the change in reference variables:
image

The CO2 concentration increases more slowly, due to a bigger zone volume and the shift from InternalWall to SlabOnGround for the floor, and OuterWall for the ceiling, with higher air leakages. This results in a shift in the PI control.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same considerations of DetailedHouse9 holds for the change in the reference results.

@annadellisola annadellisola merged commit 347884e into open-ideas:master Jul 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create separate package within IDEAS.Examples.Tutorial for Modelica crash course examples Update Tutorial IDEAS

4 participants